From f773f42839fa7c80d68bbf30790eb71f31c249f8 Mon Sep 17 00:00:00 2001
From: schneefux <schneefux+commit@schneefux.xyz>
Date: Wed, 26 Jul 2017 20:35:41 +0200
Subject: don't attempt to nack if ack fails

---
 worker.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/worker.js b/worker.js
index 6150cd1..77bbd0c 100644
--- a/worker.js
+++ b/worker.js
@@ -49,8 +49,6 @@ amqp.connect(RABBITMQ_URI).then(async (rabbit) => {
             let payload = JSON.parse(msg.content.toString()),
                 notify = msg.properties.headers.notify; // where to send progress report
             await getAPI(payload, notify);
-            logger.info("done", payload);
-            await ch.ack(msg);
         } catch (err) {
             // log, move to error queue and NACK on *any* error
             logger.error(err);
@@ -59,7 +57,10 @@ amqp.connect(RABBITMQ_URI).then(async (rabbit) => {
                 headers: msg.properties.headers
             });
             await msg.nack(false, false);
+            return;
         }
+        logger.info("done", payload);
+        await ch.ack(msg);
     }, { noAck: false });
 
     // loop over API data objects
-- 
cgit v1.3.1